lkml.org 
[lkml]   [2007]   [May]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 1/2] limit print_fatal_signal() rate (was: [RFC] log out-of-virtual-memory events)
    Date
    Bernd Eckenfels wrote:
    > In article <464DCEAB.3090905@users.sourceforge.net> you wrote:
    >> printk("%s/%d: potentially unexpected fatal signal %d.\n",
    >> current->comm, current->pid, signr);
    >
    > can we have both KERN_WARNING please?
    >
    > Gruss
    > Bernd

    Depends on print_fatal_signals patch.

    ---

    Limit the rate of print_fatal_signal() to avoid potential denial-of-service
    attacks.

    Signed-off-by: Andrea Righi <a.righi@cineca.it>

    diff -urpN linux-2.6.22-rc1-mm1/kernel/signal.c linux-2.6.22-rc1-mm1-vm-log-enomem/kernel/signal.c
    --- linux-2.6.22-rc1-mm1/kernel/signal.c 2007-05-19 11:25:24.000000000 +0200
    +++ linux-2.6.22-rc1-mm1-vm-log-enomem/kernel/signal.c 2007-05-19 11:30:00.000000000 +0200
    @@ -790,7 +790,10 @@ static void print_vmas(void)

    static void print_fatal_signal(struct pt_regs *regs, int signr)
    {
    - printk("%s/%d: potentially unexpected fatal signal %d.\n",
    + if (unlikely(!printk_ratelimit()))
    + return;
    +
    + printk(KERN_WARNING "%s/%d: potentially unexpected fatal signal %d.\n",
    current->comm, current->pid, signr);

    #ifdef __i386__
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/
    \
     
     \ /
      Last update: 2007-05-19 12:35    [W:2.403 / U:0.044 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site