lkml.org 
[lkml]   [2007]   [May]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH] LogFS take three
    Date
    On Tuesday 15 May 2007 4:37 pm, Andrew Morton wrote:

    > > +static inline struct logfs_super *LOGFS_SUPER(struct super_block *sb)
    > > +{
    > > + return sb->s_fs_info;
    > > +}
    > > +
    > > +static inline struct logfs_inode *LOGFS_INODE(struct inode *inode)
    > > +{
    > > + return container_of(inode, struct logfs_inode, vfs_inode);
    > > +}
    >
    > Do these need to be uppercase?

    I'm trying to keep it clear in my head...

    When do you need to say __always_inline and when can you get away with just
    saying "static inline"?

    (I'm attempting to write documentation on a topic I don't understand. Best
    way to learn it, I've found...)

    > > +     buf = kmap(page);
    > > +     ret = logfs_write_buf(inode, index, buf);
    > > +     kunmap(page);
    >
    > kmap() is lame.  The preferred approach would be to pass the page* down to
    > the lower layers and to use kmap_atomic() at the lowest possible point.

    Um, would I read about this in DMA-mapping.txt or cachetlb.txt? (I don't
    think it's fujitsu/frv/mmu-layout.txt)

    Rob
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-05-19 08:19    [W:0.044 / U:95.552 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site