lkml.org 
[lkml]   [2007]   [May]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [2.6 patch] drivers/net/wireless/libertas/fw.c: fix use-before-check
    This should be sent to linux-wireless (and CC'ed to me) as well...

    On Sat, May 19, 2007 at 01:06:49AM +0800, Eugene Teo wrote:
    > NULL checks should be performed before the dereference.
    >
    > Spotted by the Coverity checker.
    >
    > Signed-off-by: Eugene Teo <eteo@redhat.com>
    >
    > diff --git a/drivers/net/wireless/libertas/fw.c b/drivers/net/wireless/libertas/fw.c
    > index 441123c..5c63c9b 100644
    > --- a/drivers/net/wireless/libertas/fw.c
    > +++ b/drivers/net/wireless/libertas/fw.c
    > @@ -333,18 +333,22 @@ static void command_timer_fn(unsigned long data)
    > unsigned long flags;
    >
    > ptempnode = adapter->cur_cmd;
    > + if (ptempnode == NULL) {
    > + lbs_pr_debug(1, "PTempnode Empty\n");
    > + return;
    > + }
    > +
    > cmd = (struct cmd_ds_command *)ptempnode->bufvirtualaddr;
    > + if (!cmd) {
    > + lbs_pr_debug(1, "cmd is NULL\n");
    > + return;
    > + }
    >
    > lbs_pr_info("command_timer_fn fired (%x)\n", cmd->command);
    >
    > if (!adapter->fw_ready)
    > return;
    >
    > - if (ptempnode == NULL) {
    > - lbs_pr_debug(1, "PTempnode Empty\n");
    > - return;
    > - }
    > -
    > spin_lock_irqsave(&adapter->driver_lock, flags);
    > adapter->cur_cmd = NULL;
    > spin_unlock_irqrestore(&adapter->driver_lock, flags);
    > -
    > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    > the body of a message to majordomo@vger.kernel.org
    > More majordomo info at http://vger.kernel.org/majordomo-info.html
    > Please read the FAQ at http://www.tux.org/lkml/

    --
    John W. Linville
    linville@tuxdriver.com
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-05-18 20:07    [W:0.022 / U:0.672 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site