lkml.org 
[lkml]   [2007]   [May]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 7/15] Make ISDN CAPI use seq_list_xxx helpers
    The similar code exists here and is called capi_driver_get_idx().
    Use generic helpers now and remember to convert list_head to
    struct capi_driver in .show callback.

    Signed-off-by: Pavel Emelianov <xemul@openvz.org>

    ---

    diff --git a/drivers/isdn/capi/kcapi_proc.c b/drivers/isdn/capi/kcapi_proc.c
    index 31f4fd8..845a797 100644
    --- a/drivers/isdn/capi/kcapi_proc.c
    +++ b/drivers/isdn/capi/kcapi_proc.c
    @@ -243,36 +243,15 @@ create_seq_entry(char *name, mode_t mode

    // ---------------------------------------------------------------------------

    -
    -static __inline__ struct capi_driver *capi_driver_get_idx(loff_t pos)
    -{
    - struct capi_driver *drv = NULL;
    - struct list_head *l;
    - loff_t i;
    -
    - i = 0;
    - list_for_each(l, &capi_drivers) {
    - drv = list_entry(l, struct capi_driver, list);
    - if (i++ == pos)
    - return drv;
    - }
    - return NULL;
    -}
    -
    static void *capi_driver_start(struct seq_file *seq, loff_t *pos)
    {
    - struct capi_driver *drv;
    read_lock(&capi_drivers_list_lock);
    - drv = capi_driver_get_idx(*pos);
    - return drv;
    + return seq_list_start(&capi_drivers, *pos);
    }

    static void *capi_driver_next(struct seq_file *seq, void *v, loff_t *pos)
    {
    - struct capi_driver *drv = (struct capi_driver *)v;
    - ++*pos;
    - if (drv->list.next == &capi_drivers) return NULL;
    - return list_entry(drv->list.next, struct capi_driver, list);
    + return seq_list_next(v, &capi_drivers, pos);
    }

    static void capi_driver_stop(struct seq_file *seq, void *v)
    @@ -282,7 +261,8 @@ static void capi_driver_stop(struct seq_

    static int capi_driver_show(struct seq_file *seq, void *v)
    {
    - struct capi_driver *drv = (struct capi_driver *)v;
    + struct capi_driver *drv = list_entry(v, struct capi_driver, list);
    +
    seq_printf(seq, "%-32s %s\n", drv->name, drv->revision);
    return 0;
    }
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-05-18 11:39    [W:4.213 / U:0.036 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site