lkml.org 
[lkml]   [2007]   [May]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] powernow-k8: depend on acpi-processor for SMP systems
    On Wed, May 16, 2007 at 02:26:14PM -1000, Joshua Hoblitt wrote:
    > I don't think this is quiet right either as Ed Sweetman has reported
    > that this issue doesn't occur on single socket/multi-core systems.

    I'm not sure why [*], because this should be preventing it..

    if (num_online_cpus() != 1) {
    printk(KERN_ERR PFX "MP systems not supported by PSB BIOS structure\n");
    kfree(data);
    return -ENODEV;
    }

    num_online_cpus will return 2 in a dual-core system, even though there's
    just one socket. Given they share a power plane, if there's a valid
    PSB structure however, it may be usable. Though this isn't necessarily
    true for all future dual-core AMD CPUs, and the ACPI tables really
    should be preferred.

    Dave

    [*] unless you have the second core disabled or CONFIG_SMP=n

    --
    http://www.codemonkey.org.uk
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-05-17 02:41    [W:0.032 / U:59.920 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site