lkml.org 
[lkml]   [2007]   [May]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] recalc_sigpending_tsk fixes
On 05/16, Roland McGrath wrote:
>
> + * After recalculating TIF_SIGPENDING, we need to make sure the task wakes up.
> + * This is superfluous when called on current, the wakeup is a harmless no-op.
> + */
> +void recalc_sigpending_and_wake(struct task_struct *t)
> +{
> + if (recalc_sigpending_tsk(t))
> + signal_wake_up(t, 0);
> }

We already discussed this, this is not so important, but how about

void recalc_sigpending_and_wake(struct task_struct *t)
{
int was_pending = signal_pending(t);

if (recalc_sigpending_tsk(t) && !was_pending)
signal_wake_up(t, 0);
}

?

This "was_pending" is more a documenation than a optimization.

Oleg.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-05-17 01:45    [W:0.127 / U:0.164 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site