lkml.org 
[lkml]   [2007]   [May]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: [PATCH] LogFS take three
    Hi!

    In kernel fsck....

    > --- /dev/null 2007-04-18 05:32:26.652341749 +0200
    > +++ linux-2.6.21logfs/fs/logfs/progs/fsck.c 2007-05-15 00:54:22.000000000 +0200
    > @@ -0,0 +1,332 @@
    > +/*
    > + * fs/logfs/prog/fsck.c - filesystem check
    > + *
    > + * As should be obvious for Linux kernel code, license is GPLv2
    > + *
    > + * Copyright (c) 2005-2007 Joern Engel
    > + *
    > + * In principle this could get moved to userspace. However it might still
    > + * make some sense to keep it in the kernel. It is a pure checker and will
    > + * only report problems, not attempt to repair them.
    > + */
    Is there version that repairs?

    > + /* Some segments are reserved. Just pretend they were all valid */
    > + reserved = btree_lookup(&super->s_reserved_segments, segno);
    > + if (reserved)
    > + return 0;
    > +
    > + err = wbuf_read(sb, dev_ofs(sb, segno, 0), sizeof(sh), &sh);
    > + BUG_ON(err);

    BUG is not right thing to do for media error.

    > +/*
    > + * fs/logfs/prog/mkfs.c - filesystem generation
    > + *
    > + * As should be obvious for Linux kernel code, license is GPLv2
    > + *
    > + * Copyright (c) 2005-2007 Joern Engel
    > + *
    > + * Should get moved to userspace.
    > + */

    Indeed.

    > +
    > +#if 0
    > +/* rootdir */

    Please just delete it, not comment it out like this.

    Pavel
    --
    (english) http://www.livejournal.com/~pavelmachek
    (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-05-16 21:23    [W:0.025 / U:1.124 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site