lkml.org 
[lkml]   [2007]   [May]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: slab hang on boot
On Mon, 14 May 2007 16:46:17 -0700 (PDT)
Christoph Lameter <clameter@sgi.com> wrote:

> @@ -86,6 +87,9 @@ static inline int kmalloc_index(int size
> */
> WARN_ON_ONCE(size == 0);
>
> + if (size >= (1UL << KMALLOC_SHIFT_HIGH))
> + return -1;
> +

I don't quite understand why we did this. The subsequent logic in
kmalloc_index() should return -1 for this `size' anyway. If it doesn't,
it's bust, isn't it?

Also, afaict kmalloc_slab() will totally mishandle the -1 return value and
will return a garbage kmem_cache*, via

return &kmalloc_caches[index];


Could you double-check it all please?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-05-16 01:39    [from the cache]
©2003-2011 Jasper Spaans