lkml.org 
[lkml]   [2007]   [May]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC][PATCH 5/14] Introduce union stack

    On May 14 2007 13:23, Badari Pulavarty wrote:
    >> +static inline void union_lock_fs(struct fs_struct *fs)
    >> +{
    >> + int locked;
    >> +
    >> + while (fs) {
    >> + locked = union_trylock(fs->root);
    >> + if (!locked)
    >> + goto loop1;
    >> + locked = union_trylock(fs->altroot);
    >> + if (!locked)
    >> + goto loop2;
    >> + locked = union_trylock(fs->pwd);
    >> + if (!locked)
    >> + goto loop3;
    >> + break;
    ^^^^^^
    >> + loop3:
    >> + union_unlock(fs->altroot);
    >> + loop2:
    >> + union_unlock(fs->root);
    >> + loop1:
    >> + read_unlock(&fs->lock);
    >> + UM_DEBUG_LOCK("Failed to get all semaphores in fs_struct!\n");
    >> + cpu_relax();
    >> + read_lock(&fs->lock);
    >> + continue;
    >
    >Nit.. why "continue" ?

    There's your break. Oh right, the continue is superfluous.

    At the risk of using yet another goto, the conditional jump
    could be turned into an inconditional one, since 'fs' will
    remain valid. (Compiler smart enough to figure out?)

    >> + while (fs) {
    loop0:
    >> + locked = union_trylock(fs->root);
    >> + if (!locked)
    >> + goto loop1;
    >> + locked = union_trylock(fs->altroot);
    >> + if (!locked)
    >> + goto loop2;
    >> + locked = union_trylock(fs->pwd);
    >> + if (!locked)
    >> + goto loop3;
    >> + break;
    >> + loop3:
    >> + union_unlock(fs->altroot);
    >> + loop2:
    >> + union_unlock(fs->root);
    >> + loop1:
    >> + read_unlock(&fs->lock);
    >> + UM_DEBUG_LOCK("Failed to get all semaphores in fs_struct!\n");
    >> + cpu_relax();
    >> + read_lock(&fs->lock);
    /* continue */
    goto loop0;
    }


    Jan
    --
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-05-14 22:57    [W:0.026 / U:0.384 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site