Messages in this thread | | | Date | Mon, 14 May 2007 22:38:46 +0200 (MEST) | From | Jan Engelhardt <> | Subject | Re: [RFC][PATCH 2/14] Add a new mount flag (MNT_UNION) for union mount |
| |
On May 14 2007 15:09, Bharata B Rao wrote: > >Introduce MNT_UNION, MS_UNION and FS_WHT flags. There are the necessary flags >for doing > > mount /dev/hda3 /mnt -o union > >You need additional patches for util-linux for that to work. > >Signed-off-by: Jan Blunck <j.blunck@tu-harburg.de> >Signed-off-by: Bharata B Rao <bharata@linux.vnet.ibm.com> >--- > >+ /* Unions couldn't be writable if the filesystem >+ * doesn't know about whiteouts */ >+ err = -ENOTSUPP; >+ if ((mnt_flags & MNT_UNION) && >+ !(newmnt->mnt_sb->s_flags & MS_RDONLY) && >+ !(newmnt->mnt_sb->s_type->fs_flags & FS_WHT)) >+ goto unlock; >+
Maybe I am too biased towards unionfs/aufs, but if I have an {rw,rw} union with whiteouts disabled (delete=all in unionfs speak), then FS_WHT does not need to be supported. Your patches do not seem to do delete=all semantics, do they?
Jan -- - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |