lkml.org 
[lkml]   [2007]   [May]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/2] kbuild: Add "Section mismatch" warning whitelist for powerpc
    On Mon, 14 May 2007 08:56:52 -0500
    Kumar Gala <galak@kernel.crashing.org> wrote:

    > On May 14, 2007, at 6:06 AM, Sam Ravnborg wrote:
    >
    > > On Mon, May 14, 2007 at 06:53:32PM +0800, Li Yang wrote:
    > >> This patch fixes the following "Section mismatch" warnings when
    > >> build powerpc platforms.
    > >>
    > >> -------------
    > >> WARNING: arch/powerpc/mm/built-in.o - Section mismatch: reference to
    > >> .init.text:early_get_page from .text between
    > >> 'pte_alloc_one_kernel' (at
    > >> offset 0xc68) and 'pte_alloc_one'
    > >> WARNING: mm/built-in.o - Section mismatch: reference to
    > >> .init.text:set_up_list3s from .text between
    > >> 'kmem_cache_create' (at offset
    > >> 0x20300) and 'cache_reap'
    > >> -------------
    >
    > This warnings should be handled by __init_refok instead.
    >

    Yes, I think so.

    >
    > >> Massive warnings represented by:
    > >> -------------
    > >> WARNING: arch/powerpc/kernel/built-in.o - Section mismatch:
    > >> reference to
    > >> .init.data:.got2 from prom_entry (offset 0x0)
    > >> WARNING: arch/powerpc/platforms/built-in.o - Section mismatch:
    > >> reference to
    > >> .init.text:mpc8313_rdb_probe from .machine.desc after
    > >> 'mach_mpc8313_rdb'
    > >> (at offset 0x4)
    > >> -------------
    > >>
    > >> Signed-off-by: Li Yang <leoli@freescale.com>
    > > Acked-by: Sam Ravnborg <sam@ravnborg.org>

    I always get confused when a git-tree-owner says "acked-by" against a patch
    which falls within his tree's area. An acked-by would mean "I'm OK with
    the patch, please apply it". But I'd have expected to see a "thanks,
    applied" instead.

    If it was "Andrew: please merge and send to Linus because it's urgent and I
    can't be bothered setting up a git pull for it" then fine, but please be
    explicit about that.

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-05-14 21:35    [W:0.032 / U:0.812 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site