Messages in this thread | | | Date | Sat, 12 May 2007 06:32:29 -0400 (EDT) | From | "Robert P. J. Day" <> | Subject | undefined "pm3fb_setup()" |
| |
i'm guessing someone's already spotted this but, with "make allyesconfig" on x86:
... LD .tmp_vmlinux1 drivers/built-in.o: In function `pm3fb_init': drivers/video/pm3fb.c:977: undefined reference to `pm3fb_setup' ...
the reason seems to be this excerpt from drivers/video/pm3fb.c:
================================================================ int __init pm3fb_init(void) { /* * For kernel boot options (in 'video=pm3fb:<options>' format) */ #ifndef MODULE <----------------------- char *option = NULL;
if (fb_get_options("pm3fb", &option)) return -ENODEV; pm3fb_setup(option); #endif
return pci_register_driver(&pm3fb_driver); }
static void __exit pm3fb_exit(void) { pci_unregister_driver(&pm3fb_driver); }
#ifdef MODULE <------------------------ /* * Setup */
/* * Only necessary if your driver takes special options, * otherwise we fall back on the generic fb_setup(). */ int __init pm3fb_setup(char *options) { /* Parse user speficied options (`video=pm3fb:') */ return 0; } #endif /* MODULE */ =================================================================
so the call to pm3fb_setup() is included if MODULE is *not* defined, but the actual code for that routine is included if MODULE *is* defined. unless i've misread something.
rday -- ======================================================================== Robert P. J. Day Linux Consulting, Training and Annoying Kernel Pedantry Waterloo, Ontario, CANADA
http://fsdev.net/wiki/index.php?title=Main_Page ======================================================================== - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |