lkml.org 
[lkml]   [2007]   [May]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [patch 7/7] tidy up usermode helper waiting a bit
From
Date
[/me wonders why he was CC'ed]

> /* CLONE_VFORK: wait until the usermode helper has execve'd
> * successfully We need the data structures to stay around
> * until that is done. */
> - if (wait)
> + if (wait == UMH_WAIT_PROC)
> pid = kernel_thread(wait_for_helper, sub_info,
> CLONE_FS | CLONE_FILES | SIGCHLD);
> else
> pid = kernel_thread(____call_usermodehelper, sub_info,
> CLONE_VFORK | SIGCHLD);

Isn't that a change in behaviour? Previously it said
if (wait)
<=> if (wait != 0)
<=> if (wait != UMH_WAIT_EXEC)
or am I missing something?

johannes
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2007-05-11 21:53    [W:0.123 / U:2.236 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site