lkml.org 
[lkml]   [2007]   [May]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCHv2] at91: fix enable/disable_irq_wake symmetry in pcmcia driver
Date
On Thursday 10 May 2007, Andrew Morton wrote:

> "disable_irq_wake call must be symmetric with enable_irq_wake". hmm, OK,
> I'll take your word for it.

In the same way that enable_irq() and disable_irq() must be matched,
and for the same reasons: when the IRQ is shared between drivers,
they can't all treat enable/disable status as boolean. Those calls
mask refcountig.


> Does the present code actually fail in some manner, or what?

Yes ... runtime warnings flagging various misbehaviors associated
with refcount mismatches.

- Dave


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-05-11 08:17    [W:0.057 / U:0.328 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site