Messages in this thread | | | From | David Brownell <> | Subject | Re: [PATCHv2] at91: fix enable/disable_irq_wake symmetry in pcmcia driver | Date | Thu, 10 May 2007 23:01:56 -0700 |
| |
On Thursday 10 May 2007, Andrew Morton wrote:
> "disable_irq_wake call must be symmetric with enable_irq_wake". hmm, OK, > I'll take your word for it.
In the same way that enable_irq() and disable_irq() must be matched, and for the same reasons: when the IRQ is shared between drivers, they can't all treat enable/disable status as boolean. Those calls mask refcountig.
> Does the present code actually fail in some manner, or what?
Yes ... runtime warnings flagging various misbehaviors associated with refcount mismatches.
- Dave
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |