lkml.org 
[lkml]   [2007]   [May]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: Kconfig warnings on latest GIT
    On Fri, 11 May 2007, Simon Horman wrote:

    > On Thu, May 10, 2007 at 11:56:48AM -0500, Timur Tabi wrote:
    > > Simon Horman wrote:
    > >
    > > >>So my question is: in which Kconfig do I define "UCC_FAST_TEMP" and
    > > >>"UCC_SLOW_TEMP"? At first I thought, just put it in drivers/Kconfig, but
    > > >>that Kconfig does nothing but including other Kconfigs. I believe that if I
    > > >>submit a patch that adds "UCC_FAST_TEMP" and "UCC_SLOW_TEMP" to
    > > >>drivers/Kconfig, it will be rejected. Either that, or I'll spend six weeks
    > > >>trying to persuade everyone that it's a good idea.
    > > >>
    > > >>Does anyone have any suggestions on how I can fix this?
    > > >That does seem like a reasonable suggestion, and one that
    > > >would probably work well with the other similar problems
    > > >that have been introduced sice 2.6.21.
    > >
    > > Looks like the fix is simpler than I thought. Instead of having
    > >
    > > UCC_GETH
    > > select UCC_FAST
    > >
    > > I need to do
    > >
    > > UCC_FAST
    > > default y if UCC_GETH
    >
    > I pondered something like that, but I couldn't get it quite right :(
    >
    > > I'll have a patch that fixes this out later today.
    > >
    > > I chose the first method because I wanted each individual UCC device
    > > driver to select UCC_FAST or UCC_SLOW as appropriate, so that I
    > > wouldn't have to update arch/powerpc/sysdev/qe_lib/Kconfig every time
    > > we add a new UCC driver. Oh well.
    >
    > --
    > Horms
    > H: http://www.vergenet.net/~horms/
    > W: http://www.valinux.co.jp/en/
    >

    Try this patch:

    diff --git a/arch/powerpc/sysdev/qe_lib/Kconfig b/arch/powerpc/sysdev/qe_lib/Kconfig
    index 887739f..5de7aba 100644
    --- a/arch/powerpc/sysdev/qe_lib/Kconfig
    +++ b/arch/powerpc/sysdev/qe_lib/Kconfig
    @@ -12,6 +12,7 @@ config UCC_SLOW

    config UCC_FAST
    bool
    + default y if UCC_GETH
    default n
    select UCC
    help
    diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
    index fa489b1..b159c6c 100644
    --- a/drivers/net/Kconfig
    +++ b/drivers/net/Kconfig
    @@ -2276,7 +2276,6 @@ config GFAR_NAPI
    config UCC_GETH
    tristate "Freescale QE Gigabit Ethernet"
    depends on QUICC_ENGINE
    - select UCC_FAST
    help
    This driver supports the Gigabit Ethernet mode of the QUICC Engine,
    which is available on some Freescale SOCs.
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/
    \
     
     \ /
      Last update: 2007-05-11 03:51    [W:0.025 / U:31.172 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site