Messages in this thread | | | Date | Thu, 10 May 2007 17:33:32 -0400 | From | Mark Lord <> | Subject | Re: [PATCH] libata: add human-readable error value decoding |
| |
Jeff Garzik wrote: > Mark Lord wrote: >> Same here, but I would like to see it in there under a >> CONFIG_DEBUG_LIBATA >> kernel build option or something. Kind of like the >> "FANCY_STATUS_DUMPS" flag >> that drivers/ide used to have for this kind of stuff. > > > The long term goal is to enable verbose output with a module option > and/or sysfs knob, rather than a compile-time switch.
If we're compiling the messages into the kernel regardless, then it doesn't really make much sense to NOT show all of them on the error paths.
This stuff (fancy status dumps) is mostly just for the error paths, where more information is always a good thing.
Controlling the rest of the ata_msg_xxx stuff from sysctl is fine for non-error paths.
Cheers - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |