lkml.org 
[lkml]   [2007]   [May]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch 1/7] libata: check for AN support
On Thu, 10 May 2007 01:14:38 -0400 Jeff Garzik <jeff@garzik.org> wrote:

> Andrew Morton wrote:
> >> + * @dev: Device to which command will be sent
> >> + *
> >> + * Issue SET FEATURES - SATA FEATURES command to device @dev
> >> + * on port @ap.
> >> + *
> >> + * LOCKING:
> >> + * PCI/etc. bus probe sem.
> >> + *
> >> + * RETURNS:
> >> + * 0 on success, AC_ERR_* mask otherwise.
> >> + */
> >
> > ooh, locking and return value documentation. Often missed, and nice.
>
>
> We set high standards in the libata world ;-)
>

It seems to be working. This series is perhaps the most idiomatic and
generally kernelly-looking code I've seen in ages.

Who cares if it works? ;)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-05-10 07:29    [W:0.062 / U:0.264 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site