Messages in this thread | | | From | David Howells <> | Subject | Re: [PATCH 3/3] AFS: Implement basic file write support | Date | Thu, 10 May 2007 10:56:32 +0100 |
| |
Nick Piggin <nickpiggin@yahoo.com.au> wrote:
> Why do you call SetPageUptodate when the page is not up to date? > That leaks uninitialised data, AFAIKS.
It only seems that way. If afs_prepare_write() is called, but doesn't return an error, then afs_commit_write() will be called, and it seems that the copy in of the data will be guaranteed not to fail by the caller.
Furthermore, afs_prepare_page() will have filled in the missing bits.
And whilst all that is going on, the page lock will be help by the caller, so that no-one else can access the partially complete page.
I suppose I could call SetPageUptodate() in afs_commit_write() instead.
David - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |