Messages in this thread | | | Subject | Re: [PATCH 2/3] Add hard_irq_disable() | From | Benjamin Herrenschmidt <> | Date | Thu, 10 May 2007 19:29:06 +1000 |
| |
On Thu, 2007-05-10 at 01:53 -0700, David Miller wrote: > From: Andrew Morton <akpm@linux-foundation.org> > Date: Thu, 10 May 2007 01:50:36 -0700 > > > We discussed this a couple of months back. davem landed firmly in the > > second camp and everyone then shut up ;) > > No I landed in the first :-))) > > I think the empty lines are a waste and only serve to eat > up precious screen real-estate when reading code. > > It is possible that I used to use the empty line thing in > the past, but I definitely don't do that any more.
Yup, I used to do the other one too but nowadays, I much prefer not wasting that additional line unless specific circumstances, like I want a kind of "title" in front of a whole block of other definitions with their own comments.
Something like:
/* * foo management stuff */
/* This puts the bar in the foo */ code code code code
/* This does something you don't want to know about */ code code code code
But does it realy matter that much ? :-)
Cheers, Ben.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |