Messages in this thread | | | Date | Thu, 10 May 2007 01:49:44 -0700 (PDT) | Subject | Re: [PATCH 2/3] Add hard_irq_disable() | From | David Miller <> |
| |
From: Benjamin Herrenschmidt <benh@kernel.crashing.org> Date: Thu, 10 May 2007 18:41:45 +1000
> > > > What about my comment layout style ? I've been using that forever ... Or > > > do you mean I should use a function documentation style layout there ? > > > > /* This > > * is > > * wrong > > */ > > > > /* > > * This > > * is > > * right > > */ > > Hrm... how bad are you about that one ? I must say I prefer my style :-)
I think the "wrong" one is right because screen real-estate matters. In fact that's the one I use and enforce throughout the networking and sparc ports.
I even hand edit out those empty comment lines in patches submitted to me when I spot them. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |