lkml.org 
[lkml]   [2007]   [May]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[GFS2] Fix a bug on i386 due to evaluation order [6/34]
    From
    Date
    >From 420d2a1028b906f24e836e37089a6ad55ab1848f Mon Sep 17 00:00:00 2001
    From: Steven Whitehouse <swhiteho@redhat.com>
    Date: Sun, 18 Mar 2007 16:05:27 +0000
    Subject: [PATCH] [GFS2] Fix a bug on i386 due to evaluation order

    Since gcc didn't evaluate the last two terms of the expression in
    glock.c:1881 as a constant expression, it resulted in an error on
    i386 due to the lack of a 64bit divide instruction. This adds some
    brackets to fix the problem.

    This was reported by Andrew Morton.

    Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>
    Cc: Andrew Morton <akpm@linux-foundation.org>

    diff --git a/fs/gfs2/glock.c b/fs/gfs2/glock.c
    index e707594..b8aa816 100644
    --- a/fs/gfs2/glock.c
    +++ b/fs/gfs2/glock.c
    @@ -1880,7 +1880,7 @@ static int dump_glock(struct glock_iter *gi, struct gfs2_glock *gl)
    if (test_bit(GLF_DEMOTE, &gl->gl_flags)) {
    print_dbg(gi, " Demotion req to state %u (%llu uS ago)\n",
    gl->gl_demote_state,
    - (u64)(jiffies - gl->gl_demote_time)*1000000/HZ);
    + (u64)(jiffies - gl->gl_demote_time)*(1000000/HZ));
    }
    if (gl->gl_ops == &gfs2_inode_glops && gl->gl_object) {
    if (!test_bit(GLF_LOCK, &gl->gl_flags) &&
    --
    1.5.1.2


    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-05-01 12:11    [W:4.141 / U:0.064 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site