lkml.org 
[lkml]   [2007]   [Apr]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRE: [PATCH 2/2] NET: Multiqueue network device support.
Date
From
> -----Original Message-----
> From: David Miller [mailto:davem@davemloft.net]
> Sent: Monday, April 09, 2007 1:47 PM
> To: Waskiewicz Jr, Peter P
> Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org;
> jgarzik@pobox.com; cramerj; Kok, Auke-jan H; Leech, Christopher
> Subject: Re: [PATCH 2/2] NET: Multiqueue network device support.
>
> From: "Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@intel.com>
> Date: Mon, 9 Apr 2007 13:43:11 -0700
>
> > True, but the assignment for "dev" above also casts this void * to
> > struct net_device *:
> >
> > dev = (struct net_device *)
> > (((long)p + NETDEV_ALIGN_CONST) &
> ~NETDEV_ALIGN_CONST);
> > dev->padded = (char *)dev - (char *)p;
> >
> > Shall I remove my cast?
>
> I think so. Casts tend to be red flags during patch review,
> so don't add them when not necessary and let's remove the
> unnecessary ones too.

Will do. On a side note, I don't see my patches landing on vger again.
Did they get munched, or is majordomo lagging a bit?

Thanks,

-PJ Waskiewicz
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-04-09 22:51    [W:0.062 / U:1.248 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site