Messages in this thread | | | Date | Sat, 7 Apr 2007 13:21:27 +0400 | From | Cyrill Gorcunov <> | Subject | possible NULL pointer usage |
| |
Hi,
from the function fs/udf/inode.c:udf_fill_inode -
...
UDF_I_DATA(inode) = kmalloc(inode->i_sb->s_blocksize - sizeof(struct extendedFileEntry), GFP_KERNEL); memcpy(UDF_I_DATA(inode), bh->b_data + sizeof(struct extendedFileEntry), inode->i_sb->s_blocksize - sizeof(struct extendedFileEntry));
...
so that can lead to NULL pointer usage. udf_fill_inode() declared as 'void' and the question I have is: what is the best solution to deal with a situation if kmalloc failed? May be just mark the node as bad by calling make_bad_inode() and return from the function?
Cyrill
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |