lkml.org 
[lkml]   [2007]   [Apr]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch 18/20] clean up tsc-based sched_clock
Andrew Morton wrote:
> On Wed, 04 Apr 2007 12:12:09 -0700 Jeremy Fitzhardinge <jeremy@goop.org> wrote:
>
>
>> Three cleanups:
>> - change "instable" -> "unstable"
>> - its better to use get_cpu_var for getting this cpu's variables
>> - change cycles_2_ns to do the full computation rather than just the
>> tsc->ns scaling. Its a simpler interface, and it makes the function
>> more generally useful.
>>
>> Signed-off-by: Jeremy Fitzhardinge <jeremy@xensource.com>
>>
>> ---
>> arch/i386/kernel/sched-clock.c | 35 +++++++++++++++++++++--------------
>>
>
> I'm dropping the relevant patch from Andi's tree due to it causing
> mysterious hangs when initscripts start ondemand. So I'll need to drop
> this patch and "[patch 19/20] Add a sched_clock paravirt_op".
>

OK. That just means we need to go back to the original "Add a
sched_clock paravirt_op" follow-on patch.

> I still need to work out why that hang is happening - it is very
> mysterious. I got as far as working out that it was hanging on
> write_seqlock_irqsave(xtime_lock), then remembered that it's with
> CONFIG_SMP=n so I stomped off to bed in disgust. Later.
>

Hangs always, or just sometimes? I haven't seen any problems with it.

J
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-04-07 01:31    [from the cache]
©2003-2011 Jasper Spaans