Messages in this thread | | | Date | Fri, 6 Apr 2007 16:22:33 -0700 | From | Andrew Morton <> | Subject | Re: [patch 18/20] clean up tsc-based sched_clock |
| |
On Wed, 04 Apr 2007 12:12:09 -0700 Jeremy Fitzhardinge <jeremy@goop.org> wrote:
> Three cleanups: > - change "instable" -> "unstable" > - its better to use get_cpu_var for getting this cpu's variables > - change cycles_2_ns to do the full computation rather than just the > tsc->ns scaling. Its a simpler interface, and it makes the function > more generally useful. > > Signed-off-by: Jeremy Fitzhardinge <jeremy@xensource.com> > > --- > arch/i386/kernel/sched-clock.c | 35 +++++++++++++++++++++--------------
I'm dropping the relevant patch from Andi's tree due to it causing mysterious hangs when initscripts start ondemand. So I'll need to drop this patch and "[patch 19/20] Add a sched_clock paravirt_op".
I still need to work out why that hang is happening - it is very mysterious. I got as far as working out that it was hanging on write_seqlock_irqsave(xtime_lock), then remembered that it's with CONFIG_SMP=n so I stomped off to bed in disgust. Later. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |