lkml.org 
[lkml]   [2007]   [Apr]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: coding style for long conditions
    From
    Date
    On Fri, 2007-04-06 at 14:38 -0700, Roland Dreier wrote:
    [snip]
    > If you have a git tree handy, you can do "git show 68380b58" and see
    > that Linus himself wrote:
    >
    > if (get_wq_data(work) == cwq
    > && work_pending(work)
    > && !list_empty(&work->entry)) {
    >
    > I have to admit that I would have put the &&s at the ends of the
    > previous lines rather than where Linus put them, but... egads! Linus
    > put spaces before the &&s to line them up nicely!

    My favorite form uses only tabs and would make that look like:
    if(
    get_wq_data(work) == cwq &&
    work_pending(work) &&
    !list_empty(&work->entry)
    ) {
    ...
    ...
    }

    Putting the && at the front would be OK with me too, it does make them
    more obvious and easier to find.

    I don't find too many people who like my style but that's OK. I think
    it makes everything a lot easier to read and everything lines up with
    8-space tabs or 2 or 3 space tabs. Plus, reformatting other people's
    code gives me a good chance to read it as I go. :-)
    --
    Zan Lynx <zlynx@acm.org>
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2007-04-06 23:53    [W:0.020 / U:59.456 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site