lkml.org 
[lkml]   [2007]   [Apr]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 51/90] ARM: OMAP: osk+mistral backlight, power, board specific
    * Randy Dunlap <randy.dunlap@oracle.com> [070404 15:11]:
    > On Wed, 4 Apr 2007 14:05:30 -0400 Tony Lindgren wrote:
    >
    > > From: David Brownell <dbrownell@users.sourceforge.net>
    > >
    > > Mistral-specific:
    > >
    > > - Add PWL-driven LCD backlight device
    > >
    > > - Apply power to the board even when the LCD isn't configured; things
    > > like EEPROM, temperature sensor, and wakeup switch depend on it.
    > >
    > > Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
    > > Signed-off-by: Tony Lindgren <tony@atomide.com>
    > > ---
    > > arch/arm/mach-omap1/board-osk.c | 22 ++++++++++++++++++++++
    > > 1 files changed, 22 insertions(+), 0 deletions(-)
    > >
    > > diff --git a/arch/arm/mach-omap1/board-osk.c b/arch/arm/mach-omap1/board-osk.c
    > > index 253c539..df9681d 100644
    > > --- a/arch/arm/mach-omap1/board-osk.c
    > > +++ b/arch/arm/mach-omap1/board-osk.c
    > > @@ -373,6 +386,15 @@ static void __init osk_mistral_init(void)
    > > } else
    > > printk(KERN_ERR "OSK+Mistral: wakeup button is awol\n");
    > >
    > > + /* LCD: backlight, and power; power controls other devices on the
    > > + * board, like the touchscreen, EEPROM, and wakeup (!) switch.
    > > + */
    > > + omap_cfg_reg(PWL);
    > > + if (omap_request_gpio(2) == 0) {
    > > + omap_set_gpio_direction(2, 0 /* out */);
    > > + omap_set_gpio_dataout(2, 1 /* on */);
    >
    > Some #defined values would be better than those comments.

    Adding OMAP_GPIO_OUT/ON defines could be fixed later on for all
    omap_set_gpio_direction/dataout().

    Regards,

    Tony
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-04-05 17:31    [W:5.198 / U:0.048 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site