lkml.org 
[lkml]   [2007]   [Apr]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 73/90] ARM: OMAP: Add onennand board specific support for N800
    On Wed,  4 Apr 2007 14:05:52 -0400 Tony Lindgren wrote:

    > From: Jarkko Lavinen <jarkko.lavinen@nokia.com>
    >
    > Add onennand board specific support for N800
    >
    > Signed-off-by: Jarkko Lavinen <jarkko.lavinen@nokia.com>
    > Signed-off-by: Tony Lindgren <tony@atomide.com>
    > ---
    > arch/arm/mach-omap2/board-n800-flash.c | 97 +++++++++++++++++++++++++++++++-
    > include/asm-arm/arch-omap/onenand.h | 1 +
    > 2 files changed, 97 insertions(+), 1 deletions(-)
    >
    > diff --git a/arch/arm/mach-omap2/board-n800-flash.c b/arch/arm/mach-omap2/board-n800-flash.c
    > index cd302ab..4005cfb 100644
    > --- a/arch/arm/mach-omap2/board-n800-flash.c
    > +++ b/arch/arm/mach-omap2/board-n800-flash.c

    > static struct omap_onenand_platform_data n800_onenand_data = {
    > .cs = 0,
    > .gpio_irq = 26,
    > .parts = n800_partitions,
    > - .nr_parts = 0 /* filled later */
    > + .nr_parts = 0, /* filled later */
    > + .onenand_setup = n800_onenand_setup
    > };

    FYI, it's common practice to put a comma at the end of the last
    item, like

    > + .onenand_setup = n800_onenand_setup,

    That won't generate a syntax error (with gcc) and it allows someone
    to add lines after it without touching that line (e.g., like the
    nr_parts line here).


    ---
    ~Randy
    *** Remember to use Documentation/SubmitChecklist when testing your code ***
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-04-04 22:44    [from the cache]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site