lkml.org 
[lkml]   [2007]   [Apr]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 25/90] ARM: OMAP: h4 must have blinky leds!!
Date
On Wednesday 04 April 2007 12:00 pm, Randy Dunlap wrote:
> On Wed, 4 Apr 2007 14:05:04 -0400 Tony Lindgren wrote:
>
> > +static int __init fpga_init(void)
> > +{
> > + if (machine_is_omap_h4()
> > + || machine_is_omap_h3()
> > + || machine_is_omap_h2()
> > + || machine_is_omap_perseus2()
> > + )
>
> Perhaps there is nothing in CodingStyle for if () continuation
> lines. Looks like it is needed. This is ETOOMUCHINDENTATION by
> at least one tab. Should be more like:
>
> + if (machine_is_omap_h4()
> + || machine_is_omap_h3()
> + || machine_is_omap_h2()
> + || machine_is_omap_perseus2())

That's clearly wrong -- it uses non-tab characters for indents.

Which means that unless you think

if (this_longthing
|| that longthing
|| another
...)
the condition;
is correct (nope!), those additional conditions need more indents.

>
> (without getting into where the "||" should be placed).
>
> > + return platform_driver_register(&led_driver);
> > + return 0;
> > +}
> > +fs_initcall(fpga_init);
>
> fs, eh?

That basically means "after subsys init and before other drivers", yes?
For platform level init code, that's a fairly significant category.

- Dave
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-04-04 21:20    [from the cache]
©2003-2011 Jasper Spaans