lkml.org 
[lkml]   [2007]   [Apr]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 35/90] ARM: OMAP: speed up gpio irq handling
    Date
    From: David Brownell <dbrownell@users.sourceforge.net>

    Speedup and shrink GPIO irq handling code, by using a pointer
    that's available in the irq_chip structure instead of calling
    the get_gpio_bank() function. On OMAP1 this saves 44 words,
    most of which were in IRQ critical path methods. Hey, every
    few instructions help.

    Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
    Signed-off-by: Tony Lindgren <tony@atomide.com>
    ---
    arch/arm/plat-omap/gpio.c | 17 +++++++++--------
    1 files changed, 9 insertions(+), 8 deletions(-)

    diff --git a/arch/arm/plat-omap/gpio.c b/arch/arm/plat-omap/gpio.c
    index eb9245b..83613f7 100644
    --- a/arch/arm/plat-omap/gpio.c
    +++ b/arch/arm/plat-omap/gpio.c
    @@ -584,7 +584,7 @@ static int gpio_irq_type(unsigned irq, unsigned type)
    && (type & (IRQ_TYPE_LEVEL_LOW|IRQ_TYPE_LEVEL_HIGH)))
    return -EINVAL;

    - bank = get_gpio_bank(gpio);
    + bank = get_irq_chip_data(irq);
    spin_lock(&bank->lock);
    retval = _set_gpio_triggering(bank, get_gpio_index(gpio), type);
    if (retval == 0) {
    @@ -823,7 +823,7 @@ static int gpio_wake_enable(unsigned int irq, unsigned int enable)

    if (check_gpio(gpio) < 0)
    return -ENODEV;
    - bank = get_gpio_bank(gpio);
    + bank = get_irq_chip_data(irq);
    retval = _set_gpio_wakeup(bank, get_gpio_index(gpio), enable);

    return retval;
    @@ -1038,7 +1038,7 @@ static void gpio_irq_handler(unsigned int irq, struct irq_desc *desc)
    static void gpio_irq_shutdown(unsigned int irq)
    {
    unsigned int gpio = irq - IH_GPIO_BASE;
    - struct gpio_bank *bank = get_gpio_bank(gpio);
    + struct gpio_bank *bank = get_irq_chip_data(irq);

    _reset_gpio(bank, gpio);
    }
    @@ -1046,7 +1046,7 @@ static void gpio_irq_shutdown(unsigned int irq)
    static void gpio_ack_irq(unsigned int irq)
    {
    unsigned int gpio = irq - IH_GPIO_BASE;
    - struct gpio_bank *bank = get_gpio_bank(gpio);
    + struct gpio_bank *bank = get_irq_chip_data(irq);

    _clear_gpio_irqstatus(bank, gpio);
    }
    @@ -1054,7 +1054,7 @@ static void gpio_ack_irq(unsigned int irq)
    static void gpio_mask_irq(unsigned int irq)
    {
    unsigned int gpio = irq - IH_GPIO_BASE;
    - struct gpio_bank *bank = get_gpio_bank(gpio);
    + struct gpio_bank *bank = get_irq_chip_data(irq);

    _set_gpio_irqenable(bank, gpio, 0);
    }
    @@ -1063,7 +1063,7 @@ static void gpio_unmask_irq(unsigned int irq)
    {
    unsigned int gpio = irq - IH_GPIO_BASE;
    unsigned int gpio_idx = get_gpio_index(gpio);
    - struct gpio_bank *bank = get_gpio_bank(gpio);
    + struct gpio_bank *bank = get_irq_chip_data(irq);

    _set_gpio_irqenable(bank, gpio_idx, 1);
    }
    @@ -1092,7 +1092,7 @@ static void mpuio_ack_irq(unsigned int irq)
    static void mpuio_mask_irq(unsigned int irq)
    {
    unsigned int gpio = OMAP_MPUIO(irq - IH_MPUIO_BASE);
    - struct gpio_bank *bank = get_gpio_bank(gpio);
    + struct gpio_bank *bank = get_irq_chip_data(irq);

    _set_gpio_irqenable(bank, gpio, 0);
    }
    @@ -1100,7 +1100,7 @@ static void mpuio_mask_irq(unsigned int irq)
    static void mpuio_unmask_irq(unsigned int irq)
    {
    unsigned int gpio = OMAP_MPUIO(irq - IH_MPUIO_BASE);
    - struct gpio_bank *bank = get_gpio_bank(gpio);
    + struct gpio_bank *bank = get_irq_chip_data(irq);

    _set_gpio_irqenable(bank, gpio, 1);
    }
    @@ -1275,6 +1275,7 @@ static int __init _omap_gpio_init(void)
    #endif
    for (j = bank->virtual_irq_start;
    j < bank->virtual_irq_start + gpio_count; j++) {
    + set_irq_chip_data(j, bank);
    if (bank_is_mpuio(bank))
    set_irq_chip(j, &mpuio_irq_chip);
    else
    --
    1.4.4.2
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-04-04 20:53    [W:4.060 / U:0.128 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site