lkml.org 
[lkml]   [2007]   [Apr]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH 11/14] get_unmapped_area handles MAP_FIXED on ramfs (nommu)
    Date
    Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:

    > - if (!(flags & MAP_SHARED))
    > + /* Deal with MAP_FIXED differently ? Forbid it ? Need help from some nommu
    > + * folks there... --BenH.
    > + */
    > + if ((flags & MAP_FIXED) || !(flags & MAP_SHARED))

    MAP_FIXED on NOMMU? Surely you jest...

    See the first if-statement in validate_mmap_request().

    If anything, you should be adding BUG_ON(flags & MAP_FIXED).

    David
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-04-04 12:19    [from the cache]
    ©2003-2011 Jasper Spaans