lkml.org 
[lkml]   [2007]   [Apr]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 11/36] Use menuconfig objects II - IPMI
    I checked this out and it seems to work fine.  This does seem a little
    nicer than the way it was, so if this is the way the kernel is heading
    I'll ack it.

    -corey

    Jan Engelhardt wrote:
    > Change Kconfig objects from "menu, config" into "menuconfig" so
    > that the user can disable the whole feature without having to
    > enter the menu first.
    >
    > Signed-off-by: Jan Engelhardt <jengelh@gmx.de>
    >
    > ---
    > drivers/char/ipmi/Kconfig | 12 ++++--------
    > 1 file changed, 4 insertions(+), 8 deletions(-)
    >
    > --- linux-2.6.21-mm_20070428.orig/drivers/char/ipmi/Kconfig
    > +++ linux-2.6.21-mm_20070428/drivers/char/ipmi/Kconfig
    > @@ -2,8 +2,7 @@
    > # IPMI device configuration
    > #
    >
    > -menu "IPMI"
    > -config IPMI_HANDLER
    > +menuconfig IPMI_HANDLER
    > tristate 'IPMI top-level message handler'
    > help
    > This enables the central IPMI message handler, required for IPMI
    > @@ -16,9 +15,10 @@ config IPMI_HANDLER
    >
    > If unsure, say N.
    >
    > +if IPMI_HANDLER
    > +
    > config IPMI_PANIC_EVENT
    > bool 'Generate a panic event to all BMCs on a panic'
    > - depends on IPMI_HANDLER
    > help
    > When a panic occurs, this will cause the IPMI message handler to
    > generate an IPMI event describing the panic to each interface
    > @@ -38,14 +38,12 @@ config IPMI_PANIC_STRING
    >
    > config IPMI_DEVICE_INTERFACE
    > tristate 'Device interface for IPMI'
    > - depends on IPMI_HANDLER
    > help
    > This provides an IOCTL interface to the IPMI message handler so
    > userland processes may use IPMI. It supports poll() and select().
    >
    > config IPMI_SI
    > tristate 'IPMI System Interface handler'
    > - depends on IPMI_HANDLER
    > help
    > Provides a driver for System Interfaces (KCS, SMIC, BT).
    > Currently, only KCS and SMIC are supported. If
    > @@ -53,15 +51,13 @@ config IPMI_SI
    >
    > config IPMI_WATCHDOG
    > tristate 'IPMI Watchdog Timer'
    > - depends on IPMI_HANDLER
    > help
    > This enables the IPMI watchdog timer.
    >
    > config IPMI_POWEROFF
    > tristate 'IPMI Poweroff'
    > - depends on IPMI_HANDLER
    > help
    > This enables a function to power off the system with IPMI if
    > the IPMI management controller is capable of this.
    >
    > -endmenu
    > +endif # IPMI_HANDLER
    >

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-04-30 16:47    [W:0.024 / U:2.828 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site