Messages in this thread | | | Subject | Re: [PATCH] Cleanup and kernelify shrinker registration (rc5-mm2) | From | Rusty Russell <> | Date | Tue, 03 Apr 2007 17:18:25 +1000 |
| |
On Mon, 2007-04-02 at 23:09 -0700, Andrew Morton wrote: > hm, well, six-of-one, VI of the other. We save maybe four kmallocs across > the entire uptime at the cost of exposing stuff kernel-side which doesn't > need to be exposed.
This is not about efficiency. When have I *ever* posted optimization patches?
This is about clarity. We have a standard convention for register/unregister. And they can't fail. Either of these would be sufficient to justify a change.
Too many people doing cool new things in the kernel, not enough polishing of the crap that's already there 8(
> But I think we need to weed that crappiness out of XFS first.
Sure, I'll apply on top of that patch.
Thanks! Rusty.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |