lkml.org 
[lkml]   [2007]   [Apr]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [patches] [PATCH] [21/22] x86_64: Extend bzImage protocol for relocatable bzImage
From
Date
On Sun, 2007-04-29 at 09:11 -0600, Eric W. Biederman wrote:
> Right now I'm a little frustrated that insanity below slipped into
> head.S right after the 32bit entry point after the review said
> use the normal linux parameters for parameter passing.
>
> > #ifdef CONFIG_PARAVIRT
> > movl %cs, %eax
> > testl $0x3, %eax
> > jnz startup_paravirt
> > #endif
>
> The whole thing should be based on a value in the linux parameter block
> pointed to by %esi, instead of the insane preserve all registers and
> attempt to be super compatible with everyone.

Dammit, Eric, you spend a lot of time using words like "insane" where
you mean we didn't do everything all at once.

It's *not* clear that using %esi is sane, but nothing in the current
code prevents that.

I was trying to get Xen to use this entry point rather than their own: I
failed, and only lguest now uses it.

Fortunately, this also means it's trivial to change.
Rusty.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-04-30 05:05    [W:0.216 / U:0.096 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site