lkml.org 
[lkml]   [2007]   [Apr]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH 04/21] sysfs: move release_sysfs_dirent() to dir.c
    Date
    From
    There is no reason this function should be inlined and soon to follow
    sysfs object reference simplification will make it heavier. Move it
    to dir.c.

    Signed-off-by: Tejun Heo <htejun@gmail.com>
    ---
    fs/sysfs/dir.c | 12 ++++++++++++
    fs/sysfs/sysfs.h | 13 +------------
    2 files changed, 13 insertions(+), 12 deletions(-)

    diff --git a/fs/sysfs/dir.c b/fs/sysfs/dir.c
    index 85a6686..4dc4322 100644
    --- a/fs/sysfs/dir.c
    +++ b/fs/sysfs/dir.c
    @@ -14,6 +14,18 @@

    DECLARE_RWSEM(sysfs_rename_sem);

    +void release_sysfs_dirent(struct sysfs_dirent * sd)
    +{
    + if (sd->s_type & SYSFS_KOBJ_LINK) {
    + struct sysfs_symlink * sl = sd->s_element;
    + kfree(sl->link_name);
    + kobject_put(sl->target_kobj);
    + kfree(sl);
    + }
    + kfree(sd->s_iattr);
    + kmem_cache_free(sysfs_dir_cachep, sd);
    +}
    +
    static void sysfs_d_iput(struct dentry * dentry, struct inode * inode)
    {
    struct sysfs_dirent * sd = dentry->d_fsdata;
    diff --git a/fs/sysfs/sysfs.h b/fs/sysfs/sysfs.h
    index a77c57e..3b8aae0 100644
    --- a/fs/sysfs/sysfs.h
    +++ b/fs/sysfs/sysfs.h
    @@ -17,6 +17,7 @@ extern void sysfs_delete_inode(struct inode *inode);
    extern struct inode * sysfs_new_inode(mode_t mode, struct sysfs_dirent *);
    extern int sysfs_create(struct dentry *, int mode, int (*init)(struct inode *));

    +extern void release_sysfs_dirent(struct sysfs_dirent * sd);
    extern int sysfs_dirent_exist(struct sysfs_dirent *, const unsigned char *);
    extern int sysfs_make_dirent(struct sysfs_dirent *, struct dentry *, void *,
    umode_t, int);
    @@ -97,18 +98,6 @@ static inline struct kobject *sysfs_get_kobject(struct dentry *dentry)
    return kobj;
    }

    -static inline void release_sysfs_dirent(struct sysfs_dirent * sd)
    -{
    - if (sd->s_type & SYSFS_KOBJ_LINK) {
    - struct sysfs_symlink * sl = sd->s_element;
    - kfree(sl->link_name);
    - kobject_put(sl->target_kobj);
    - kfree(sl);
    - }
    - kfree(sd->s_iattr);
    - kmem_cache_free(sysfs_dir_cachep, sd);
    -}
    -
    static inline struct sysfs_dirent * sysfs_get(struct sysfs_dirent * sd)
    {
    if (sd) {
    --
    1.5.0.3

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-04-28 15:49    [W:0.030 / U:0.352 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site