lkml.org 
[lkml]   [2007]   [Apr]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH -mm 2/2] Introduce freezer flags
    Date
    On Friday, 27 April 2007 23:40, Gautham R Shenoy wrote:
    > On Fri, Apr 27, 2007 at 05:40:16PM +0200, Rafael J. Wysocki wrote:
    > > From: Rafael J. Wysocki <rjw@sisk.pl>
    > >
    > > Move all of the freezer-related flags to a separate field in task_struct and
    > > introduce functions to operate them using set_bit() etc.
    > >
    > >
    > > Index: linux-2.6.21-rc7-mm2/include/linux/sched.h
    > > ===================================================================
    > > --- linux-2.6.21-rc7-mm2.orig/include/linux/sched.h
    > > +++ linux-2.6.21-rc7-mm2/include/linux/sched.h
    > > @@ -1006,7 +1006,10 @@ struct task_struct {
    > > /* Deadlock detection and priority inheritance handling */
    > > struct rt_mutex_waiter *pi_blocked_on;
    > > #endif
    > > -
    > > +#ifdef CONFIG_FREEZER
    > > + /* Used by the process freezer, defined in freezer.h */
    > > + unsigned int freezer_flags;
    >
    > unsigned long freezer_flags; ??

    I guess so.

    > Else it throws the following warnings.

    On which arch is that? I've tested on x86_64 ...

    > include/linux/freezer.h: In function `frozen':
    > include/linux/freezer.h:22: warning: passing arg 2 of
    > `constant_test_bit' from incompatible pointer type
    > include/linux/freezer.h:22: warning: passing arg 2 of
    > `variable_test_bit' from incompatible pointer type
    > include/linux/freezer.h: In function `set_frozen_flag':
    > include/linux/freezer.h:27: warning: passing arg 2 of `set_bit' from
    > incompatible pointer type
    > include/linux/freezer.h: In function `clear_frozen_flag':
    > include/linux/freezer.h:32: warning: passing arg 2 of `clear_bit' from
    > incompatible pointer type
    > include/linux/freezer.h: In function `freezing':
    > include/linux/freezer.h:40: warning: passing arg 2 of
    > `constant_test_bit' from incompatible pointer type
    > include/linux/freezer.h:40: warning: passing arg 2 of
    > `variable_test_bit' from incompatible pointer type
    > include/linux/freezer.h: In function `freeze':
    > include/linux/freezer.h:48: warning: passing arg 2 of `set_bit' from
    > incompatible pointer type
    > include/linux/freezer.h: In function `clear_freeze_flag':
    > include/linux/freezer.h:56: warning: passing arg 2 of `clear_bit' from
    > incompatible pointer type
    > include/linux/freezer.h: In function `freezer_should_exempt':
    > include/linux/freezer.h:64: warning: passing arg 2 of
    > `constant_test_bit' from incompatible pointer type
    > include/linux/freezer.h:64: warning: passing arg 2 of
    > `variable_test_bit' from incompatible pointer type
    > include/linux/freezer.h: In function `freezer_exempt':
    > include/linux/freezer.h:72: warning: passing arg 2 of `set_bit' from
    > incompatible pointer type
    > include/linux/freezer.h: In function `freezer_do_not_count':
    > include/linux/freezer.h:132: warning: passing arg 2 of `set_bit' from
    > incompatible pointer type
    > include/linux/freezer.h: In function `freezer_count':
    > include/linux/freezer.h:142: warning: passing arg 2 of `clear_bit' from
    > incompatible pointer type
    > include/linux/freezer.h: In function `freezer_should_skip':
    > include/linux/freezer.h:152: warning: passing arg 2 of
    > `constant_test_bit' from incompatible pointer type
    > include/linux/freezer.h:152: warning: passing arg 2 of
    > `variable_test_bit' from incompatible pointer type

    Greetings,
    Rafael
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-04-27 23:49    [W:0.026 / U:1.456 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site