lkml.org 
[lkml]   [2007]   [Apr]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 44/46] mod_sysfs_setup() doesn't return errno when kobject_add_dir() failure occurs
    Date
    From: Akinobu Mita <akinobu.mita@gmail.com>

    mod_sysfs_setup() doesn't return an errno when kobject_add_dir() for module
    "holders" directory fails. So caller of mod_sysfs_setup() will keep going
    and get oops.

    Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
    Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    ---
    kernel/module.c | 4 +++-
    1 files changed, 3 insertions(+), 1 deletions(-)

    diff --git a/kernel/module.c b/kernel/module.c
    index dcdb32b..9da5af6 100644
    --- a/kernel/module.c
    +++ b/kernel/module.c
    @@ -1148,8 +1148,10 @@ int mod_sysfs_setup(struct module *mod,
    goto out;

    mod->holders_dir = kobject_add_dir(&mod->mkobj.kobj, "holders");
    - if (!mod->holders_dir)
    + if (!mod->holders_dir) {
    + err = -ENOMEM;
    goto out_unreg;
    + }

    err = module_param_sysfs_setup(mod, kparam, num_params);
    if (err)
    --
    1.5.1.2
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-04-27 21:05    [W:4.127 / U:0.100 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site