lkml.org 
[lkml]   [2007]   [Apr]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 26/46] IDE: remove rwsem use from ide-proc core
    Date
    The subsystem rwsem is not used by the driver core at all, so the use of
    it in the ide-proc code of it doesn't make any sense. Perhaps a local
    lock might be needed, but I do not really think so.

    Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
    Cc: linux ide <linux-ide@vger.kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    ---
    drivers/ide/ide-proc.c | 4 ----
    1 files changed, 0 insertions(+), 4 deletions(-)

    diff --git a/drivers/ide/ide-proc.c b/drivers/ide/ide-proc.c
    index afb71c6..a9e0b30 100644
    --- a/drivers/ide/ide-proc.c
    +++ b/drivers/ide/ide-proc.c
    @@ -310,14 +310,12 @@ static int proc_ide_read_driver
    ide_driver_t *ide_drv;
    int len;

    - down_read(&dev->bus->subsys.rwsem);
    if (dev->driver) {
    ide_drv = container_of(dev->driver, ide_driver_t, gen_driver);
    len = sprintf(page, "%s version %s\n",
    dev->driver->name, ide_drv->version);
    } else
    len = sprintf(page, "ide-default version 0.9.newide\n");
    - up_read(&dev->bus->subsys.rwsem);
    PROC_IDE_READ_RETURN(page,start,off,count,eof,len);
    }

    @@ -327,7 +325,6 @@ static int ide_replace_subdriver(ide_drive_t *drive, const char *driver)
    int ret = 1;
    int err;

    - down_write(&dev->bus->subsys.rwsem);
    device_release_driver(dev);
    /* FIXME: device can still be in use by previous driver */
    strlcpy(drive->driver_req, driver, sizeof(drive->driver_req));
    @@ -345,7 +342,6 @@ static int ide_replace_subdriver(ide_drive_t *drive, const char *driver)
    }
    if (dev->driver && !strcmp(dev->driver->name, driver))
    ret = 0;
    - up_write(&dev->bus->subsys.rwsem);

    return ret;
    }
    --
    1.5.1.2
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-04-27 21:01    [W:4.031 / U:0.060 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site