Messages in this thread | | | Subject | Re: driver power operations (was Re: suspend2 merge) | From | Johannes Berg <> | Date | Fri, 27 Apr 2007 14:46:42 +0200 |
| |
On Fri, 2007-04-27 at 14:40 +0200, Pavel Machek wrote:
> > Five callbacks are fine by me, especially if we can define reasonable defaults > > for the hibernation (and can we?). > > Well, we still can default to suspend(PMSG_FREEZE) for freeze(), and > resume() for thaw(). Anything else is just not sane way forward.
I think we should remove the argument to suspend() in the same patch series. Yes, that would mean porting all drivers that currently use it, but that's not actually all that many since most drivers are dumbed-down wrt. power management.
And realistically, resume for thaw makes no sense, nor does suspend for freeze, so we probably want to change those over to suspend/restart and use them. or something.
johannes [unhandled content-type:application/pgp-signature] | |