Messages in this thread | | | Date | Thu, 26 Apr 2007 12:35:26 +0100 | From | Christoph Hellwig <> | Subject | Re: suspend2 merge (was Re: [Suspend2-devel] Re: CFS and suspend2: hang in atomic copy) |
| |
On Thu, Apr 26, 2007 at 12:17:12PM +0200, Johannes Berg wrote: > On Tue, 2007-04-24 at 23:24 +0200, Pavel Machek wrote: > > > I believe uswsusp user/kernel separation is clean enough. Kernel > > provides "snapshot image" and "resume image". (Thanks go to Rafael for > > very clean interface). > > The interface isn't even 64/32-bit compatible...
It's not . And it's one of the worst interface I've seen lately. Did anyone actually review this crap before it went in? I completely agree with Linus that these kind of boundaries that lead to horribly complex ioctl interface are totally wrong.
Now suspend2 wasn't exactly nice either when I last reviewed it, but we should probably give it another attempt if we can sort out a proper incremental merge.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |