lkml.org 
[lkml]   [2007]   [Apr]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    SubjectRE: [PATCH] ide-cs: recognize 2GB CompactFlash from Transcend
    Date
    From
    As pointed to by Peter, and also as indicated by a judicious output in
    dmesg, the 4th parameter should be 0x969aa4f2. Please find below the
    corrected patch:

    Signed-off-by: Fabrice Aeschbacher <fabrice.aeschbacher@siemens.com>

    ===================================================================
    --- linux-2.6.20.7-orig/drivers/ide/legacy/ide-cs.c 2007-04-15
    21:08:02.000000000 +0200
    +++ linux-2.6.20.7/drivers/ide/legacy/ide-cs.c 2007-04-26
    11:13:13.000000000 +0200
    @@ -399,6 +399,7 @@
    PCMCIA_DEVICE_PROD_ID12("TOSHIBA", "MK2001MPL", 0xb4585a1a,
    0x3489e003),
    PCMCIA_DEVICE_PROD_ID1("TRANSCEND 512M ", 0xd0909443),
    PCMCIA_DEVICE_PROD_ID12("TRANSCEND", "TS1GCF80", 0x709b1bf1,
    0x2a54d4b1),
    + PCMCIA_DEVICE_PROD_ID12("TRANSCEND", "TS2GCF120", 0x709b1bf1,
    0x969aa4f2),
    PCMCIA_DEVICE_PROD_ID12("TRANSCEND", "TS4GCF120", 0x709b1bf1,
    0xf54a91c8),
    PCMCIA_DEVICE_PROD_ID12("WIT", "IDE16", 0x244e5994, 0x3e232852),
    PCMCIA_DEVICE_PROD_ID12("WEIDA", "TWTTI", 0xcc7cf69c,
    0x212bb918),
    ===================================================================

    > -----Original Message-----
    > From: Andrew Morton [mailto:akpm@linux-foundation.org]
    > Sent: Donnerstag, 26. April 2007 02:16
    > To: Aeschbacher, Fabrice
    > Cc: linux-pcmcia@lists.infradead.org; lkml; Dominik
    > Brodowski; Bartlomiej Zolnierkiewicz
    > Subject: Re: [PATCH] ide-cs: recognize 2GB CompactFlash from Transcend
    >
    > On Wed, 25 Apr 2007 11:27:09 +0200 "Aeschbacher, Fabrice"
    > <Fabrice.Aeschbacher@siemens.com> wrote:
    >
    > > Without the following patch, the kernel does not
    > automatically detect
    > > 2GB CompactFlash cards from Transcend.
    > >
    > > I'm not sure which correct values must be assigned to the
    > 3th and 4th
    > > parameters (here: 0x709b1bf1, 0xf54a91c8). Anyway, the patch is
    > > working with these values. Tested on arch=mips.
    > >
    >
    > Thanks. Your patch was wordwrapped and had tabs replaced by
    > spaces, btw.
    >
    > >
    > > ===================================================================
    > > --- linux-2.6.20.7-orig/drivers/ide/legacy/ide-cs.c 2007-04-15
    > > 21:08:02.000000000 +0200
    > > +++ linux-2.6.20.7/drivers/ide/legacy/ide-cs.c 2007-04-25
    > > 10:53:53.000000000 +0200
    > > @@ -64,6 +64,7 @@
    > >
    > > #define INT_MODULE_PARM(n, v) static int n = v;
    > module_param(n, int,
    > > 0)
    > >
    > > +#define PCMCIA_DEBUG 1
    > > #ifdef PCMCIA_DEBUG
    > > INT_MODULE_PARM(pc_debug, PCMCIA_DEBUG); #define DEBUG(n,
    > args...)
    > > if (pc_debug>(n)) printk(KERN_DEBUG args)
    >
    > I removed the above change
    >
    > > @@ -399,6 +400,7 @@
    > > PCMCIA_DEVICE_PROD_ID12("TOSHIBA", "MK2001MPL", 0xb4585a1a,
    > > 0x3489e003),
    > > PCMCIA_DEVICE_PROD_ID1("TRANSCEND 512M ", 0xd0909443),
    > > PCMCIA_DEVICE_PROD_ID12("TRANSCEND", "TS1GCF80",
    > 0x709b1bf1,
    > > 0x2a54d4b1),
    > > + PCMCIA_DEVICE_PROD_ID12("TRANSCEND", "TS2GCF120",
    > 0x709b1bf1,
    > > 0xf54a91c8),
    > > PCMCIA_DEVICE_PROD_ID12("TRANSCEND", "TS4GCF120",
    > 0x709b1bf1,
    > > 0xf54a91c8),
    > > PCMCIA_DEVICE_PROD_ID12("WIT", "IDE16", 0x244e5994,
    > 0x3e232852),
    > > PCMCIA_DEVICE_PROD_ID12("WEIDA", "TWTTI", 0xcc7cf69c,
    > > 0x212bb918),
    >
    > I'm never sure whether it's Bart or Dominik who handles
    > pcmcia-cs patches.
    >
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-04-26 11:23    [W:0.029 / U:61.248 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site