lkml.org 
[lkml]   [2007]   [Apr]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 0/9] Kconfig: cleanup s390 v2.
    On Wed, 25 Apr 2007 14:30:11 -0700 Andrew Morton <akpm@linux-foundation.org> wrote:

    > But that only applies to things which I merge. There's heaps of stuff
    > coming in via the git trees which is obviously inadequately reviewed - look
    > at all the instances of open-coded kernel_thread() which were merged after
    > the kthread() API was introduced, for example.
    >
    >
    > And other basic stuff like "use mutexes, not semaphores":
    >
    > box:/usr/src/25> grep '^+.*[ ]down[ ]*[(]' patches/git-*.patch | wc -l
    > 32
    >
    >
    >
    > Ever wonder where all those whitespace bugs are coming from?
    >
    > box:/usr/src/25> grep '^+.*[ ]if[(]' patches/git-*.patch | wc -l
    > 265
    > box:/usr/src/25> grep '^+.*[ ]while[(]' patches/git-*.patch | wc -l
    > 35
    >
    >
    > Code which use spaces where it should be using tabs?
    >
    > box:/usr/src/25> grep '^+ ' patches/git-*.patch | wc -l
    > 1346
    >

    It would be neat if someone could create and maintain a new
    scripts/spot-common-mistakes. Feed it a unified diff and it would complain
    about newly-added code (and only newly-added code) which has busted
    whitespace, adds new semaphores, adds new kernel_thread calls, etc, etc.

    It would need to be fairly simple and easily-extensible, as I can
    imagine quite a few things getting added to it.

    (Imagines a procmail rule which just bounces the email if
    spot-common-mistakes failed)


    >
    > Heaven knows how many more serious problems are being snuck into the tree
    > via this route.

    But it won't solve this problem.
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-04-26 02:29    [W:0.034 / U:96.560 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site