lkml.org 
[lkml]   [2007]   [Apr]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] cancel_delayed_work: use del_timer() instead of del_timer_sync()
    On Wed, Apr 25, 2007 at 01:50:34AM +0400, Oleg Nesterov wrote:
    > del_timer_sync() buys nothing for cancel_delayed_work(), but it is less
    > efficient since it locks the timer unconditionally, and may wait for the
    > completion of the delayed_work_timer_fn().

    I'm not sure what is the main aim of this patch. It seems this
    change cannot do any harm, but anyway it could change a few
    things, e.g. with current version of cancel_rearming_delayed_work
    some flush_workqueue could be done needlessly, before the work
    is queued from timer. It's not a big deal here, but if anybody
    did something like this without loop - it could matter.

    So, probably a lot of current code should be checked, before
    applying and I doubt the gain is worth of this. Maybe, for
    safety, make this with new name as an alternative and
    deprecate the current version?

    Regards,
    Jarek P.
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-04-25 14:59    [W:4.355 / U:0.116 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site