This message generated a parse failure. Raw output follows here. Please use 'back' to navigate. From devnull@lkml.org Thu Apr 18 18:30:06 2024 Delivery-date: Tue, 24 Apr 2007 17:28:40 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1422800AbXDXR2P (ORCPT ); Tue, 24 Apr 2007 13:28:15 -0400 Received: from smtp1.linux-foundation.org ([65.172.181.25]:33177 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1422797AbXDXR2O convert rfc822-to-8bit (ORCPT ); Tue, 24 Apr 2007 13: Received: from shell0.pdx.osdl.net (fw.osdl.org [65.172.181.6]) by smtp1.linux-foundation.org (8.13.5.20060308/8.13.5/Debian-3ubuntu1.1) with ESMTP id l3OHR3xx000954 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 24 Apr 2007 10:27:05 -070 Received: from box (shell0.pdx.osdl.net [10.9.0.31]) by shell0.pdx.osdl.net (8.13.1/8.11.6) with SMTP id l3OHR0IE014543; Tue, 24 Apr 2007 10:27:01 -0700 Date: Tue, 24 Apr 2007 10:27:00 -0700 From: Andrew Morton To: Gerd Hoffmann Cc: linux-kernel@vger.kernel.org, Paul Mundt , Ralf Baechle , Andi Kleen , Alan Cox , Richard Henderson , Ivan Kokshaysky , Paul Macker Subject: Re: [patch v2] Fixes and cleanups for earlyprintk aka boot console. Message-Id: <20070424102700.c58f8a6d.akpm@linux-foundation.org> In-Reply-To: <462E0E60.5080907@redhat.com> References: <20070315154638.944768000@suse.de> <20070423234240.29427438.akpm@linux-foundation.org> <462E0E60.5080907@redhat.com> X-Mailer: Sylpheed version 2.2.7 (GTK+ 2.8.17; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE X-Spam-Status: No, hits=-3.676 required=5 tests=AWL,BAYES_00,OSDL_HEADER_SUBJECT_BRACKETED X-Spam-Checker-Version: SpamAssassin 3.1.0-osdl_revision__1.12__ X-MIMEDefang-Filter: osdl$Revision: 1.177 $ X-Scanned-By: MIMEDefang 2.53 on 65.172.181.25 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 24 Apr 2007 16:04:16 +0200 Gerd Hoffmann wr= ote: > > I get this, across netconsole: > >=20 > > [17179569.184000] console handover: boot [earlyvga_f=11_0] -> real = [tty0] > >=20 > > wanna take a look at why there's cruft in bootconsole->name please? >=20 > -EFULL ;) >=20 > "earlyvga" is 8 chars. struct console->name is char[8]. No space le= ft=20 > for the trailing =B4\0=B4, the cruft comes from the next field (write= =20 > function pointer). Obviously nobody ever printed the early console=20 > names before. doh. > Hmm. We can make the names shorter. We can make the name field long= er=20 > (probably 16, it ends up taking that much anyway due to aligments at=20 > least on 64bit). This looks best to me. We could also use=20 > printk("%.8s",name) to make printk stop after 8 chars, but I somehow=20 > don't like hardcoding the length like this ... >=20 yup, making it 16 sounds simplest. I'll do the patch, thanks. - To unsubscribe from this list: send the line "unsubscribe linux-kernel"= in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/