lkml.org 
[lkml]   [2007]   [Apr]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH] powerpc pseries eeh: Convert to kthread API
    From
    Date

    > The only reason for using threads here is to get the error recovery
    > out of an interrupt context (where errors may be detected), and then,
    > an hour later, decrement a counter (which is how we limit these to
    > 6 per hour). Thread reaping is "trivial", the thread just exits
    > after an hour.

    In addition, it should be a thread and not done from within keventd
    because :

    - It can take a long time (well, relatively but still too long for a
    work queue)

    - The driver callbacks might need to use keventd or do flush_workqueue
    to synchronize with their own workqueues when doing an internal
    recovery.

    > Since these are events rare, I've no particular concern about
    > performance or resource consumption. The current code seems
    > to work just fine. :-)

    I think moving to kthread's is cleaner (just a wrapper around kernel
    threads that simplify dealing with reaping them out mostly) and I agree
    with Christoph that it would be nice to be able to "fire off" kthreads
    from interrupt context.. in many cases, we abuse work queues for things
    that should really done from kthreads instead (basically anything that
    takes more than a couple hundred microsecs or so).

    Ben.


    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-04-24 03:43    [W:5.759 / U:0.052 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site