Messages in this thread | | | Date | Mon, 23 Apr 2007 14:07:00 -0500 | From | Scott Wood <> | Subject | Re: Fw: [PATCH][RFC] PCMCIA support for 8xx using platform devices |
| |
On Sun, Apr 22, 2007 at 11:26:58PM +0400, Vitaly Bordug wrote: > diff --git a/arch/powerpc/boot/dts/mpc885ads.dts b/arch/powerpc/boot/dts/mpc885ads.dts > index 90e047a..330ac91 100644 > --- a/arch/powerpc/boot/dts/mpc885ads.dts > +++ b/arch/powerpc/boot/dts/mpc885ads.dts > @@ -112,6 +112,18 @@ > compatible = "CPM"; > }; > > + pcmcia@0080 { > + linux,phandle = <0080>; > + #interrupt-cells = <1>; > + #size-cells = <2>; > + compatible = "8xx"; > + device_type = "pcmcia"; > + reg = <80 80>; > + clock-frequency = <2faf080>; > + interrupt-parent = <ff000000>; > + interrupts = <d 1>; > + }; > +
DTC supports labels now; we should be using those instead of hardcoded phandles. Also, please indent by tabs.
-Scott - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |