lkml.org 
[lkml]   [2007]   [Apr]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC][PATCH -mm 2/3] freezer: Introduce freezer_flags
    On Sun, Apr 22, 2007 at 09:39:26PM +0200, Rafael J. Wysocki wrote:
    > @@ -63,9 +100,9 @@ static inline int thaw_process(struct ta
    > */
    > static inline void frozen_process(struct task_struct *p)
    > {
    > - p->flags |= PF_FROZEN;
    > + set_frozen_flag(p);
    > wmb();
    > - clear_tsk_thread_flag(p, TIF_FREEZE);
    > + do_not_freeze(p);

    We may want to rename do_not_freeze to something else. It kind of
    looks weird calling do_not_freeze(p) after setting the frozen flag!

    Probably, just a matter of taste :-)

    > }
    >

    Thanks and Regards
    gautham.
    --
    Gautham R Shenoy
    Linux Technology Center
    IBM India.
    "Freedom comes with a price tag of responsibility, which is still a bargain,
    because Freedom is priceless!"
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-04-23 15:21    [W:0.022 / U:60.204 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site