Messages in this thread | | | Date | Sun, 22 Apr 2007 13:34:56 +0100 | From | Christoph Hellwig <> | Subject | Re: [PATCH] powerpc pseries rtasd: Convert to kthread API. |
| |
On Thu, Apr 19, 2007 at 01:58:46AM -0600, Eric W. Biederman wrote: > From: Eric W. Biederman <ebiederm@xmission.com> > > This patch modifies the startup of rtasd to use kthread_run instaed of > a combination of kernel_thread and daemonize. Making the code a little > simpler and more maintainble.
Looks okay, but I have some questions about the original code.
Why does the driver only check if it really needs to run in the thread and calls vmalloc from it? If we did all these in the initialization function we could actually properly unwind.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |