Messages in this thread | | | Date | Sun, 22 Apr 2007 10:30:46 +0530 | From | Balbir Singh <> | Subject | Re: [PATCH -mm] Taskstats fix the structure members alignment issue |
| |
Andrew Morton wrote: > On Sat, 21 Apr 2007 18:29:21 +0530 Balbir Singh <balbir@linux.vnet.ibm.com> wrote: > >>>> The patch adds an __attribute__((aligned(8))) to the >>>> taskstats structure members so that 32 bit applications using taskstats >>>> can work with a 64 bit kernel. >>> But there might be 32-bit applications out there which are using the >>> present wrong structure? >>> >>> otoh, I assume that those applications would be using taskstats.h and would >>> hence encounter this bug and we would have heard about it, is that correct? >>> >> Yes, correct. >> >>> otoh^2, 32-bit applications running under 32-bit kernels will presently be >>> functioning correctly, and your change will require that those applications >>> be recompiled, I think? >>> >> Yes, correct. They would be broken with this fix. We could bump up the >> version TASKSTATS_VERSION to 4. Would you like a new patch the version >> bumped up? > > I can do that.
Thanks
> >>> This patch looks like 2.6.20 and 2.6.21 material, but very carefully... >> Yes, 2.6.20 and 2.6.21 sound correct. > > OK. I guess we have little choice but to slam it in asap, with a 2.6.20.x backport > before too many people start using the old interface.
Thanks, again!
-- Balbir Singh Linux Technology Center IBM, ISTL - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |