lkml.org 
[lkml]   [2007]   [Apr]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 10/10] mm: per device dirty threshold
    From
    Date

    > > > +/*
    > > > + * maximal error of a stat counter.
    > > > + */
    > > > +static inline unsigned long bdi_stat_delta(void)
    > > > +{
    > > > +#ifdef CONFIG_SMP
    > > > + return NR_CPUS * FBC_BATCH;
    > >
    > > This is enormously wrong for CONFIG_NR_CPUS=1024 on a 2-way.

    Right, I knew about that but, uhm.

    I wanted to make that num_online_cpus(), and install a hotplug notifier
    to fold the percpu delta back into the total on cpu offline.

    But I have to look into doing that hotplug notifier stuff.

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-04-21 14:19    [W:0.021 / U:0.032 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site